Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target(npm): Cleanup "next" tag when releasing newer version #399

Open
kamilogorek opened this issue May 30, 2022 · 0 comments
Open

target(npm): Cleanup "next" tag when releasing newer version #399

kamilogorek opened this issue May 30, 2022 · 0 comments

Comments

@kamilogorek
Copy link
Contributor

Currently, when we release a preview version (beta, alpha, or RC), it publishes it with next tag on the NPM registry:

https://github.com/getsentry/craft/blob/master/src/targets/npm.ts#L181-L189

However, when after a few iterations we perform a complete release, with a non-preview version, this tag is never cleaned up, and it points to the older version than latest, which is not valid by definition, as next should always point to at least latest (or newer).

It would be nice if we could detect that the next was pointing at the preview version of the "about to be released" version, and if that is the case, call npm dist-tag rm @sentry/node next to clean it up.

An example from @sentry/node repository:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant