Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release drafts persist after failed publish attempt #388

Open
kamilogorek opened this issue Apr 27, 2022 · 0 comments
Open

Release drafts persist after failed publish attempt #388

kamilogorek opened this issue Apr 27, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@kamilogorek
Copy link
Contributor

When publish action fails, either due to an error, or a timeout, a pre-created draft release will be left untouched.

This means, that whenever someone reapproves the release, they can end up with multiple drafts and a single published release, with the same tag names, which is polluting our GitHub releases page.

It's not possible to query for non-published releases by tag, nor are they listed in /releases endpoint, so we cannot just remove or reuse an existing one, as for this, we need a release ID value, which we don't know.

It'd be best to call deleteRelease in the catch clause of the main publish step if anything goes wrong.
However now, due to the timeouts issue that we are trying to resolve, it would not work as well, so leaving this issue description here for future reference.

@kamilogorek kamilogorek added the bug Something isn't working label Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant