Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GitHub asset upload retry algorithm #337

Open
chadwhitacre opened this issue Dec 15, 2021 · 3 comments
Open

Improve GitHub asset upload retry algorithm #337

chadwhitacre opened this issue Dec 15, 2021 · 3 comments

Comments

@chadwhitacre
Copy link
Member

Seen a few times now that we can get an intermittent asset upload failure from GitHub. Do we have a retry already for that? How about it?

@rhcarvalho @iker-barriocanal Do you recall the retry conversation we had earlier? Was it around GitHub asset uploads?

@BYK
Copy link
Contributor

BYK commented Dec 16, 2021

We try up to 3 times:

retries = 3

We can probably increase it and also add some delay?

@iker-barriocanal
Copy link
Member

@chadwhitacre it was about asset downloads.

@rhcarvalho
Copy link
Contributor

Looking at the code at

craft/src/targets/github.ts

Lines 394 to 396 in 03fda08

if (!(err instanceof RequestError)) {
throw err;
}
, I am not sure if the retry logic is working as expected. @chadwhitacre's https://github.com/getsentry/publish/runs/4540082749?check_suite_focus=true#step:8:169 did have 3x 500 requests to the failed asset, but I don't see a "Reached maximum retries..." error.

image

We need getsentry/publish#665 to get better stack traces :)

+1 to potentially a few more retries and exponential backoff.

@chadwhitacre chadwhitacre changed the title Retry GitHub asset uploads Improve GitHub asset upload retry algorithm Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants