Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using srcset will result in very pixelated images #6366

Open
runxel opened this issue Mar 24, 2024 · 3 comments
Open

Using srcset will result in very pixelated images #6366

runxel opened this issue Mar 24, 2024 · 3 comments
Labels
needs: replication 🔬 Requires a sample to reproduce the issue

Comments

@runxel
Copy link

runxel commented Mar 24, 2024

Description

When using srcset the output will be very pixelated. See below.
First I thought I might only be in cases when there is upscaling (btw: it would be super cool to have a config option that disables that). However I limited it for a test in my config.php and in the command itself ($image->srcset([100, 300])) so it would never upscale images. The results did not change though, which leads me to believe it's an issue with Kirby itself.
I have only checked .jpg's so far.

Expected behavior

Srcset should be looking good, not pixelated.

Screenshots

This image is originally twice the size and was "downscaled" here to 1024px (w).
srcsetissue

To reproduce

Use srcset anywhere in your code.
Look at the result.

Your setup

Kirby Version

3.10.0.1
I know, it's not 4, so I doubt it will get fixed.

Your system (please complete the following information)

  • Device: MacBook
  • OS: macOS
  • Browser: Firefox
  • Version: 123

Additional context
Issue started after the update to PHP 8.0 and installing 3.10.0.1

@texnixe
Copy link
Member

texnixe commented Mar 24, 2024

In 3.10., we dropped support for PHP 8.0 and added support for PHP 8.3, so you should not use this version with PHP 8.0. Also, are you using the GD library or ImageMagick as thumb driver?

Yes, 3.x only gets security support, but I doubt that this is a Kirby issue.

@runxel
Copy link
Author

runxel commented Mar 25, 2024

In 3.10., we dropped support for PHP 8.0 and added support for PHP 8.3, so you should not use this version with PHP 8.0.

Sorry, misspelled. It's on PHP 8.1 I believe.

Also, are you using the GD library or ImageMagick as thumb driver?

I didn't change the defaults, so it should be GD. (And yeah, it's probably not a Kirby issue, but I hoped for some insight)

@distantnative distantnative added the needs: replication 🔬 Requires a sample to reproduce the issue label Apr 1, 2024
@rasteiner
Copy link
Contributor

rasteiner commented Apr 22, 2024

Reminds me of https://forum.getkirby.com/t/image-assets-pixelated-on-frontend-after-kirby-update/29672
We never figured out what happened there either.

Edit: summary is that images look like that when for some reason the quality gets set to 0. We never actually found out why a 0 gets used, and under what circumstances, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: replication 🔬 Requires a sample to reproduce the issue
Projects
None yet
Development

No branches or pull requests

4 participants