Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scale selector to make it compatible with different projections #10322

Open
1 task done
offtherailz opened this issue May 14, 2024 · 0 comments · May be fixed by #10344
Open
1 task done

Fix scale selector to make it compatible with different projections #10322

offtherailz opened this issue May 14, 2024 · 0 comments · May be fixed by #10344
Assignees
@mahmoudadel54
Labels
bug C277-REGION_DE_MURCIA-2024-SUPPORT
Milestone
2024.01.02

Comments

@offtherailz
Copy link
Member

offtherailz commented May 14, 2024 •
edited by tdipisa

Description

When switching between projections, the scale selector becomes buggy and is not responding correctly.

How to reproduce

I tested this locally and I verified that the issue you find happens even without the projection, so also switching in EPSG:4326 from Web mercator
Here I recorded the evolution of the state locally that can be used for the investigation .

screencast-bpconcjcammlapcogcnnelfmaeghhagj-2024.05.06-10_43_51.webm

Expected Result
The selector should be consistent with the map and the final print.

Current Result
When switching SRS, the selector do not work.

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

Review to be assigned to @offtherailz
Connected support issue https://github.com/geosolutions-it/support/issues/3313
@tdipisa tdipisa added this to the 2024.01.01 milestone May 14, 2024
@tdipisa tdipisa assigned mahmoudadel54 and unassigned tdipisa May 14, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue May 20, 2024
@mahmoudadel54
geosolutions-it#10322: Fix scale selector to make it compatible with …
8f23219 
…different projections

Description:
- fix the bug by using the updated scaleZoom value instead of the projected value
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue May 20, 2024
@mahmoudadel54
geosolutions-it#10322: Fix scale selector to make it compatible with …
6cbb710 
…different projections

Description:
- add helpful comment
@mahmoudadel54 mahmoudadel54 linked a pull request May 20, 2024 that will close this issue
Open
12 tasks
@mahmoudadel54 mahmoudadel54 linked a pull request May 20, 2024 that will close this issue
#10322: Fix scale selector to make it compatible with different projections #10344
Open
12 tasks
@tdipisa tdipisa modified the milestones: 2024.01.01, 2024.01.02 May 28, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue May 30, 2024
@mahmoudadel54
geosolutions-it#10322: Fix scale selector to make it compatible with …
138ae35 
…different projections

Description:
- fix not compatablity projections issue
- add unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mahmoudadel54 mahmoudadel54

Labels
bug C277-REGION_DE_MURCIA-2024-SUPPORT
Projects
None yet
Milestone
2024.01.02
Development

Successfully merging a pull request may close this issue.

#10322: Fix scale selector to make it compatible with different projections mahmoudadel54/MapStore2
3 participants
@offtherailz @tdipisa @mahmoudadel54