Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using pre-commit #1347

Open
2 tasks done
lnxpy opened this issue Nov 10, 2023 · 5 comments · May be fixed by #1449
Open
2 tasks done

Using pre-commit #1347

lnxpy opened this issue Nov 10, 2023 · 5 comments · May be fixed by #1449
Assignees

Comments

@lnxpy
Copy link

lnxpy commented Nov 10, 2023

Search before asking

  • I have searched the EvaDB issues and found no similar feature requests.

Description

Use pre-commit for a better Development Experience and more stable contributions.

Use case

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
Copy link
Contributor

👋 Hello @lnxpy, thanks for your interest in EVA DB 🙏 Please visit our 🔮 Tutorials to get started, where you can find quickstart guides for simple tasks like Image Classification all the way to more interesting tasks like Emotion Analysis.

If this is a 🐞 Bug Report, please provide a minimum reproducible example to help us debug it.

If this is a ❓ Question, please provide as much information as possible, including dataset examples and query results.

@xzdandy
Copy link
Collaborator

xzdandy commented Nov 10, 2023

Could you add more details on how you plan to use pre commit to improve the experience? Thanks!

@lnxpy
Copy link
Author

lnxpy commented Nov 12, 2023

Hi @xzdandy. Sure. The only checkpoint that you have in your docs is checking the formatting of changes via Black. We can automate that process and ensure that the devs do format their changes before making any PR.

@lnxpy
Copy link
Author

lnxpy commented Nov 23, 2023

Hi @xzdandy. I just need a quick update on both this one and #1348 issues. May I start working?!

Thanks.

@xzdandy
Copy link
Collaborator

xzdandy commented Nov 23, 2023

Yes. Sounds good to me!

@lnxpy lnxpy linked a pull request Mar 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants