Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aren't the \b in the UUID regex superfluous? #89

Open
guillaumealgis opened this issue Mar 14, 2022 · 2 comments
Open

Aren't the \b in the UUID regex superfluous? #89

guillaumealgis opened this issue Mar 14, 2022 · 2 comments

Comments

@guillaumealgis
Copy link

guillaumealgis commented Mar 14, 2022

I'm not convinced the \b in the UUID regex serve any purpose. Why are we trying to match word boundaries here?

^[0-9a-fA-F]{8}\b-[0-9a-fA-F]{4}\b-[0-9a-fA-F]{4}\b-[0-9a-fA-F]{4}\b-[0-9a-fA-F]{12}$

(I tested the regex without the \b and the same strings match or don't match)

@alex-hofmann do you remember why you added those?

@alex-hofmann
Copy link
Contributor

@guillaumealgis apologies for seeing this [not quite] a year since you asked. There's no reason for them, that I can remember, and with fresh eyes I would not include them.

It looks like the \b's are still out there, so one of us can likely PR an edit

@guillaumealgis
Copy link
Author

@alex-hofmann no worries ☺️

I won't bother with a PR, the repo hasn't seen activity since sept 2021 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants