Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointing on PCs as action target should also highlight their portrait #2064

Open
1 of 4 tasks
MarcelHB opened this issue Mar 15, 2024 · 3 comments
Open
1 of 4 tasks

Comments

@MarcelHB
Copy link
Collaborator

MarcelHB commented Mar 15, 2024

Bug description

In the original, when choosing an attack or a spell on a PC, both the ground circle and the portrait border should have an oscillating white-green effect. For GemRB, it's only the ground circle right now.

This is helpful if the tooltip is delayed and you have no clue who's under cursor exactly, but a look at the avatar reveals that.

Steps to reproduce

  1. Pick a spell with an actor target.
  2. Point to one of the party members

Expected behavior

Green-white avatar frame pulses, as for the ground circles.

GemRB version (check as many as you know apply)

  • master as of this issue
  • 0.9.2
  • 0.9.1
  • 0.9.0
@lynxlynxlynx
Copy link
Member

Basically whenever the cursor is over a pc, also their portrait's border should oscillate. And vice versa for the selection one. Currently we only oscillate the border when hovering over the selected pc's portrait. So we should have all the tools already, it's just that some are maybe done on the python side.

@bradallred
Copy link
Member

This also happens when speaking. At least in BG2.

@lynxlynxlynx
Copy link
Member

For posterity, #1414 has a better description of the oscillation:

The circle flashes between black, color of the circle* and white (* cyan for npcs, green for party members, red for enemies).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants