PST floating window should close on right click

[burner1024]

Bug description

Floating menu doesn't close on right click.

Steps to reproduce

1. Load game.
2. Right click once.
3. Right click again.

Expected behavior

Second right click should close the menu and unpause game.

Screenshots

If applicable, add screenshots to help explain your problem.

GemRB version (check as many as you know apply)

• master as of this issue
• 0.9.2
• 0.9.1
• 0.9.0

Video Driver (check as many as you know apply)

• SDL1.2
• SDL2 built with OPENGL_BACKEND enabled
• SDL2 without OPENGL_BACKEND enabled

[lynxlynxlynx]

Windows aren't clickable, so I guess the easiest way is to add extra callbacks to all the buttons, which will cover the vast majority of cases.

[bradallred]

Looking at the original, right clicks anywhere toggle it. So it's not a window event. I think what you want to do is add another event monitor in GameControl to listen to right clicks and move the logic out of OnMouseDown.

the other half is adding a function to actually toggle the window like we do with CreateTopWinLoader and invoke that instead.