Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BG1: Screens are exited as soon as the character is on the marker level #2014

Open
2 of 7 tasks
bsdcode opened this issue Feb 22, 2024 · 3 comments
Open
2 of 7 tasks

Comments

@bsdcode
Copy link
Contributor

bsdcode commented Feb 22, 2024

Bug description

Characters switch screens as soon as they are almost on the same level as the marker. They do not go the whole way. Example is the second floor of the Candlekeep Inn. If you select to go downstairs then the character will not go the whole way around the stairs and not actually step down the stairs. Instead it will switch to the first floor as soon as it has passed the marker. The screenshot shows the marker at the stairs and the mousepointer shows roughly the position at which the character will switch screens to the first floor. It will not go around the stair railings.

Expected behavior

Character goes the whole way to the marker before switching screens.

Screenshots

bg1_gemrb

GemRB version (check as many as you know apply)

  • master as of this issue
  • 0.9.2
  • 0.9.1
  • 0.9.0

Video Driver (check as many as you know apply)

  • SDL1.2
  • SDL2 built with OPENGL_BACKEND enabled
  • SDL2 without OPENGL_BACKEND enabled
@burner1024
Copy link
Contributor

I think the originals don't go the whole way necessarily, but they do go closer than this.

@bsdcode
Copy link
Contributor Author

bsdcode commented Feb 22, 2024

Yes, the originals go halfway down the stairs before the area is changed. The green marker in the screenshot is the position at which the area is changed.

bg1_wine

@lynxlynxlynx
Copy link
Member

It could be several of our constants for good-enough that's causing us to stop pathing. MAX_OPERATING_DISTANCE, the cutoff in the pathfinder, something else in the actual movement logic ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants