Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the sed_path variable still needed #191

Open
dkrutsko opened this issue Jan 4, 2024 · 2 comments
Open

Is the sed_path variable still needed #191

dkrutsko opened this issue Jan 4, 2024 · 2 comments
Labels

Comments

@dkrutsko
Copy link

dkrutsko commented Jan 4, 2024

Looking into the sudoers task and git blame, I see that sed_path was defined for use in Vagrant. However, I can no longer see any references to this variable. Am I missing something or could these two tasks be removed? https://github.com/geerlingguy/mac-dev-playbook/blob/master/tasks/sudoers.yml#L2-L12

@geerlingguy
Copy link
Owner

@dkrutsko - Yeah... I don't think they're necessary anymore—I don't use them in any of the roles either. I'd accept a PR to nuke 'em.

Copy link

github-actions bot commented May 9, 2024

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

@github-actions github-actions bot added the stale label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants