Fix game crashing when player dies. Instead, game restarts. #101
Conversation
…om the beginning.
There was a problem hiding this comment.
Thanks for the help, the code needs changes though. You can find our contributors' guide here if you need a hand with the git workflow: https://www.gdquest.com/open-source/guidelines/contributing-to-gdquest-projects/ (NB: still a work in progress)
| @@ -45,6 +45,8 @@ func fall(gap_size): | |||
|
|
|||
| func _on_Die_finished(string): | |||
| set_dead(true) | |||
| get_tree().change_scene("res://Demo.tscn") | |||
There was a problem hiding this comment.
This shouldn't be in the player script. Rather in a file like Game.gd or something similar.
| @@ -37,7 +37,8 @@ func _unhandled_input(event): | |||
| _change_state('attack') | |||
| get_tree().set_input_as_handled() | |||
| return | |||
| current_state.handle_input(event) | |||
| if current_state: | |||
There was a problem hiding this comment.
This shouldn't be part of the same commit as it's unrelated. Also, I have to check the code but I feel it's not the right fix to keep the code maintainable. There shouldn't be cases where the input gets forwarded to a nonexistent state.
There was a problem hiding this comment.
It's because the player performed queue_free so the old reference does not exist anymore.
Additionally _unhandled_input is an internal engine method so it can't be avoided without other changes. I would suggest not doing queue_free on the player and instead just setting to a Dead state.
There was a problem hiding this comment.
I have to get back into the code, the state machine should belong to the player and be freed with it. And yeah it probably shouldn't call queue_free upon dying then.
Fixes #93
Let me know if you'd like this handled in a different way.
I did the simplest way possible, but I could also add a "Game Over" screen if you could specify exactly how it should look like.