Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating elements with same name in one diagram is not strict enough #7

Open
mrpetro opened this issue Jan 5, 2018 · 1 comment
Open

Comments

@mrpetro
Copy link
Contributor

mrpetro commented Jan 5, 2018

Current NClass allows to have elements (doesn't matter what type they are) having same name under one diagram. This leads to very odd situations when trying to delete or copy elements with duplicated names. It also causes bad code to be generated for C# and Java.
Following picture shows rules that elements naming should follow:
duplicated naming rules

@gbaychev
Copy link
Owner

gbaychev commented Jan 6, 2018

Yep, a better name validation in the class diagrams is needed. Currently I can think of the following 3 cases:

  • create a new element. Then a duplicate name should be disallowed
  • copy a element. The new elements should be renamed according to some scheme. E.g Shape_Copy1, Shape_Copy2, etc.
  • Maybe deserializing also. Not quite sure about it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants