-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't drag multiple items due to automatic deselection #65
Comments
Thank you for reporting this, it could be that it is a regression. I'm going to check it after the holidays. |
This also allows to deselect/select when doing multiple elements selection holding ctrl/shift. The problem is that, if you have two selected elements and if you click one of them, it won't clear the selection. But this is the same behaviour as the original NClass
So, it is indeed a regression from the original version. I broke it when I tried to implement the usual 'add/remove to/from selection when holding ctrl and/or shift' logic, which you can find in the most desktop apps today. The ctrl/shift thing should work now, the only caveat is, that if you have multiple elements selecting, click one of them won't remove the rest from the selection (if they get removed, then the regression happens). But this is also the behavior in the original NClass. |
Repro steps:
Expectation: Both classes remain selected and get dragged around.
Reality: The second class gets deselected and only the one where dragging started gets moved.
This can be worked around by holding shift when starting drag on unselected item, but this is quite cumbersome.
I believe this is a regression from original NClass.
The text was updated successfully, but these errors were encountered: