-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't annotate nodes with NotManagedByMCM
annotation
#774
Comments
Proposed solution We can instead annotate the nodes which are managed by MCM with the annotation
Another solution is to use
A mix of the two solutions could be used as well. cc @unmarshall @elankath for more comments |
You can pass a command line flag. If it detects that it is running in a K8S environment then it will default to pod-name. If it detects that it is not running in a pod then it will fail if the command line flag (name) is not provided. |
For local cases, one can just fallback to the local host name. |
panicing for not providing the hostname ? I think falling back to local host name , and printing log for it , should be good enough. |
Yes hostname should serve as long as you are going to start a single process locally. If you wish to start more than one process locally then that will again not work.
Well its like any other required parameter that you pass to the command line. How is this going to be any different? |
Yes multiple case would be a problem, then making it required in local case is the only way to go. |
a solution proposed in issue #718 could also be used. |
How to categorize this issue?
/area usability
/kind enhancement
/priority 3
What would you like to be added:
Currently any node which is added to the cluster and is not managed by MCM is annotated with
node.machine.sapcloud.io/notManagedByMCM": "1"
This is a problem when there are two MCM's acting on the same target cluster from different control namespaces. This is usually the scenario in the IT we perform today.
In such a case because one MCM couldn't see the machine objects for other MCM which is in another namespace, it marks the node of the other MCM with this annotation.
And this way all the machines end up getting marked with the annotation.
Why is this needed:
The text was updated successfully, but these errors were encountered: