Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor import issues in spripting.md #3312

Open
3 tasks
hulsed opened this issue May 20, 2024 · 4 comments
Open
3 tasks

Minor import issues in spripting.md #3312

hulsed opened this issue May 20, 2024 · 4 comments

Comments

@hulsed
Copy link
Contributor

hulsed commented May 20, 2024

Describe the bug

Two issues with the jupyter notebook:

To Reproduce

(see above)

Expected behavior

The imports should be somewhere in the notebook so it can be reproduced (and ideally, with some explanation of where they are coming from).

OS

N/A

  • Linux (Please put in notes the specific distro)
  • macOS
  • Windows

Version

Version of Gaphor: N/A

Additional information

Add any other context about the problem here.

@danyeaw
Copy link
Member

danyeaw commented May 27, 2024

Hi @hulsed, thanks! Would you be interested in submitting a PR?

@hulsed
Copy link
Contributor Author

hulsed commented May 28, 2024

I would, but I'm assuming the markdown was generated from a jupyter source file (.ipynb) that isn't in the repo--is that not correct?

@amolenaar
Copy link
Member

amolenaar commented May 28, 2024

The markdown file (scripting.md) is the only source. It contains special blocks that are executed by jupyter when the site is built.

.ipynb files are not source control friendly.

Edit: it looks like the code blocks that contain errors are not executed (do not have {code-cell} ipython3). That's why the issues survive. It would be better to make them executable. This is probably the only way to ensure the examples do actually work.

@danyeaw
Copy link
Member

danyeaw commented May 29, 2024

I tried to update them all during the last PR to update the scripting docs and I got build failures that I had to back out. I would recommend changing them incrementally to code cells and test one by one by rebuilding the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants