Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aria-*] attributes do not match their roles #824

Open
saidaLachgar opened this issue Jun 23, 2023 · 2 comments
Open

[aria-*] attributes do not match their roles #824

saidaLachgar opened this issue Jun 23, 2023 · 2 comments

Comments

@saidaLachgar
Copy link

Issue description: slides are lowering google insights score because of Accessibility, is it possible to avoid using [aria-*] attributes ? same thing for buttons, they don't have an aria label if i changed the controlsText to svg icons
Tiny-slider version: 2.9.4
Browser name && version: Any
OS name && version: Any

image
image

@chuckneely
Copy link

chuckneely commented Jun 26, 2023

⬆️ Second this, our Accessibility score is being impacted negatively due to the same error in TNS slides/controls:

"[aria-*] attributes do not match their roles".

Ideally it would be great if we had control over the aria labels/roles, or that they should have valid implementation by default

@szildaniel
Copy link

@ganlanyuan Same problem in project that I work on. BtW Thank you for your outstanding work on the slider. I appreciate your dedication. Would be grat If you provide the option for controlling ARIA elements within the slider :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants