Multiple loggers having an empty string as name, OK?

[N-Dekker]

Is it OK to have multiple loggers (spdlog::logger objects) in an application that all have an empty string "" as name (as specified by the name parameter of the constructors of spdlog::logger)? I'm asking because it seems to me that our application does not really need those loggers to be named.

[tt4g]

default_logger uses an empty string for its name.

spdlog/include/spdlog/details/registry-inl.h

Lines 37 to 49 in 927cc29

	#ifndef SPDLOG_DISABLE_DEFAULT_LOGGER
	// create default logger (ansicolor_stdout_sink_mt or wincolor_stdout_sink_mt in windows).
	# ifdef _WIN32
	auto color_sink = std::make_shared<sinks::wincolor_stdout_sink_mt>();
	# else
	auto color_sink = std::make_shared<sinks::ansicolor_stdout_sink_mt>();
	# endif
	const char *default_logger_name = "";
	default_logger_ = std::make_shared<spdlog::logger>(default_logger_name, std::move(color_sink));
	loggers_[default_logger_name] = default_logger_;
	#endif // SPDLOG_DISABLE_DEFAULT_LOGGER

Loggers with the same name cannot be registered in the global registry.

spdlog/include/spdlog/details/registry-inl.h

Lines 298 to 303 in 927cc29

	SPDLOG_INLINE void registry::register_logger_(std::shared_ptr<logger> new_logger)
	{
	auto logger_name = new_logger->name();
	throw_if_exists_(logger_name);
	loggers_[logger_name] = std::move(new_logger);
	}

You can avoid name conflicts by replacing the default logger with spdlog::set_default_logger().

[N-Dekker]

Thanks @tt4g I did not yet try the global registry, but I see what you mean!