Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support converting chrono::NaiveDate to Dart #1833

Open
TrackerSB opened this issue Mar 24, 2024 · 4 comments
Open

Support converting chrono::NaiveDate to Dart #1833

TrackerSB opened this issue Mar 24, 2024 · 4 comments
Labels
awaiting Waiting for responses, PR, further discussions, upstream release, etc enhancement New feature or request

Comments

@TrackerSB
Copy link
Contributor

TrackerSB commented Mar 24, 2024 •
edited

Recent updates of the dependency to allo-isolate introduced support chrono::NaiveDate in FRB. However, when converting a Rust struct containing a field of type chrono::NaiveDate a (working 馃憤馃徎) Dart class which extends from RustOpaque is generated.

Despite the fact that this should be enough to technically utilize the Dart class it would be much nicer if it generated a field of type DateTime instead of depending on RustOpaque. This enables quite more capabilities on the Dart side. In my case especially reflection.
@TrackerSB TrackerSB added the enhancement New feature or request label Mar 24, 2024
@TrackerSB TrackerSB mentioned this issue Mar 24, 2024
Closed
5 tasks
@fzyzcjy
Copy link
Owner

fzyzcjy commented Mar 24, 2024

Sure! Looking forward to reviewing and merging #1834 :)

@TrackerSB TrackerSB mentioned this issue May 18, 2024
Closed
5 tasks
@stale Stale
Copy link

stale bot commented May 25, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 25, 2024
@TrackerSB
Copy link
Contributor Author

It is still currently worked on trying to keep up with resolving conflicts with origin/master and adapting to CI requirements.

@stale stale bot removed the wontfix This will not be worked on label May 25, 2024
@fzyzcjy fzyzcjy added the awaiting Waiting for responses, PR, further discussions, upstream release, etc label Jun 21, 2024
@fzyzcjy
Copy link
Owner

fzyzcjy commented Jun 21, 2024

(Mark as awaiting since there is ongoing PR, thus the issue is awaiting PR)

@TrackerSB TrackerSB changed the title Support converting chrono::NativeDate to Dart Support converting chrono::NaiveDate to Dart Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting Waiting for responses, PR, further discussions, upstream release, etc enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@fzyzcjy @TrackerSB