Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions: repeated use of a namespace for different steps leads to incomplete installation #283

Open
jsuchome opened this issue Oct 22, 2021 · 0 comments
Assignees
Labels
area/installer Installation related requests

Comments

@jsuchome
Copy link
Member

When fuseml is creating a namespace while installing an extension, it labels it so to mark itself as the creator of such namespace. Later, if such labeled namespace is detected, it will not reinstall the content of said namespace (unless explicitly requested).

Now, ideal case if there's one namespace for an extension and it is not needed for extension steps. But we might such situation:

extension E
extension namespace: not defined
install steps:

  • step 1:
    helm chart
    namespace: X
  • step 2:
    script that needs to check some stuff before applying next step
    namespace: not defined (therefor we cannot have global namespace for the whole extension)
  • step 3:
    manifest file
    namespace X

In such case, the actions in step 3 would be skipped because fuseml already created such namespace and would think next attempt to use it means reinstallation. The installation would be incomplete.

@jsuchome jsuchome self-assigned this Oct 22, 2021
@jsuchome jsuchome added the area/installer Installation related requests label Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/installer Installation related requests
Projects
None yet
Development

No branches or pull requests

1 participant