Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

marshmallow-jsonschema is not compatible with marshmallow.fields.Enum added in marshmallow v3.18.0 #169

Open
hf-kklein opened this issue Sep 16, 2022 · 1 comment · May be fixed by #170
Open

marshmallow-jsonschema is not compatible with marshmallow.fields.Enum added in marshmallow v3.18.0 #169

hf-kklein opened this issue Sep 16, 2022 · 1 comment · May be fixed by #170

Comments

@hf-kklein
Copy link
Contributor

marshmallow_jsonschema.exceptions.UnsupportedValueError: unsupported field type <fields.Enum(dump_default=<marshmallow.missing>, attribute=None, validate=None, required=False, load_only=False, dump_only=False, load_default=<marshmallow.missing>, allow_none=False, error_messages={'required': 'Missing data for required field.', 'null': 'Field may not be null.', 'validator_failed': 'Invalid value.', 'unknown': 'Must be one of: {choices}.'})>

See changelog: https://github.com/marshmallow-code/marshmallow/blob/dev/CHANGELOG.rst#3180-2022-09-15
@hf-kklein hf-kklein mentioned this issue Sep 16, 2022
Draft
hf-kklein added a commit to hf-kklein/marshmallow-jsonschema that referenced this issue Oct 9, 2022
@hf-kklein
✔ Add (failing) unit tests
d7de079 
to reproduce the issue fuhrysteve#169
improve test setup
hf-kklein added a commit to hf-kklein/marshmallow-jsonschema that referenced this issue Oct 9, 2022
@hf-kklein
Add Support for marshmallow.fields.Enum in marshmallow >= v3.18
76c77f3 
This fixes fuhrysteve#169.
Detailed changes:
* Introduce distinction between Enums imports from `marshmallow_enum` and `marshmallow.fields` (the latter are refered to as "marshmallow native" Enums
* Add function to find out if the version of marshmallow used supports the native Enum type
* Add test cases that reproduce the issue
* Adapt the code to also support the native enums
hf-kklein added a commit to hf-kklein/marshmallow-jsonschema that referenced this issue Oct 9, 2022
@hf-kklein
Add Support for marshmallow.fields.Enum in marshmallow >= v3.18
13b57a2 
This fixes fuhrysteve#169.

Detailed changes:
* Introduce distinction between Enums imports from `marshmallow_enum` and `marshmallow.fields` (the latter are refered to as "marshmallow native" Enums)
* Add function to find out if the version of marshmallow used supports the native Enum type
* Add test cases that reproduce the issue
* Adapt the code to also support the native enums
@hf-kklein hf-kklein linked a pull request Oct 9, 2022 that will close this issue
Open
@hf-kklein
Copy link
Contributor Author

I opened a PR that fixes this issue: #170

hf-kklein added a commit to hf-kklein/marshmallow-jsonschema that referenced this issue Oct 9, 2022
@hf-kklein
Add Support for marshmallow.fields.Enum in marshmallow ≥ v3.18
d8e6476 
This fixes fuhrysteve#169.

Detailed changes:
* Introduce distinction between Enums imports from `marshmallow_enum` and `marshmallow.fields` (the latter are refered to as "marshmallow native" Enums)
* Add function to find out if the version of marshmallow used supports the native Enum type
* Add test cases that reproduce the issue
* Adapt the code to also support the native enums
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Support for marshmallow.fields.Enum in marshmallow ≥ v3.18 hf-kklein/marshmallow-jsonschema
1 participant
@hf-kklein