Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings from marshmallow #158

Open
lindycoder opened this issue Oct 15, 2021 · 0 comments
Open

Deprecation warnings from marshmallow #158

lindycoder opened this issue Oct 15, 2021 · 0 comments

Comments

@lindycoder
Copy link

Hello!

First, thank you for the tool!

I noticed there are some warnings from marshmallow that needs to be addressed:

since marshmallow>=3.10.0 marshmallow-code/marshmallow@013abfd

RemovedInMarshmallow4Warning: Passing field metadata as a keyword arg is deprecated. Use the explicit `metadata=...` argument instead.

since marshmallow>=3.13.0 marshmallow-code/marshmallow@1db1a8a

RemovedInMarshmallow4Warning: The 'default' attribute of fields is deprecated. Use 'dump_default' instead.

Currently this project supports marshmallow>=3, so here are some ideas:

  • Fix both warnings and bump requirements.txt to marshmallow>=3.13.0
  • Keep current requirements and try to use new features in code, like use metadata= and dump_default= when detecting marhsmallow<3.13 (not sure if possible)
  • Ignore those and change the requirements to marshmallow>=3,<4

Another idea?

I'll be happy to help following your guidance.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant