Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support enums when their value is a string type #156

Open
palchicz opened this issue Oct 5, 2021 · 1 comment
Open

Comments

@palchicz
Copy link

palchicz commented Oct 5, 2021

When serializing an enum to json schema, there is a check to make sure the LoadDumpOption is not by value

raise NotImplementedError(

The code comment states:

Python allows enum values to be almost anything, so it's easier to just load from the
names of the enum's which will have to be strings.

Could this restriction be loosened to include when all the enum values are strings? That way, enums like...

class MyEnum(Enum):
    STR1 = "str1"
    STR2 = "str2"
    STR3 = "str3"

...would be supported when the field is set by value.

@stretch4x4
Copy link

I think an alternative solution could be the following:

class MyEnum(str, Enum):
    STR1 = "str1"
    STR2 = "str2"
    STR3 = "str3"

This seems to work for my use cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants