Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support data_key #107

Open
DeoLeung opened this issue Feb 29, 2020 · 4 comments
Open

support data_key #107

DeoLeung opened this issue Feb 29, 2020 · 4 comments

Comments

@DeoLeung
Copy link

we have some schema using unqualified names like 2019, 1abc, we use data_key to support it

class A(Schema):
  a = fields.String(data_key='2019')

we would like it to be dumped as

{'2019': {'title': '2019', 'type': 'string'}

it's now dumped as

{'a': {'title': 'a', 'type': 'string'}
@fuhrysteve
Copy link
Owner

Looks like there's been some progress here: #100 but the tests aren't currently passing on that branch

@ZoranPavlovic
Copy link

I can pick this up as I'm in need of it. @fuhrysteve - want me to take the other Lundalogik branch to preserve his commits, or start a fresh one with their changes included?

@martijnthe
Copy link
Contributor

Fixed by #139 ?

@rw-access
Copy link

I still see this as of marshmallow-jsonschema==0.11.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants