Manually adding player does not show list of teams

[makkoli]

Players tab > Manually adding a new player

The team dropdown is supposed to have a list of all the teams, but nothing is displayed.

[BenHagan]

This getCurrTeams selector reduces the teams returned to the component to only those that are a part of an active season:

league-for-good/client/src/components/dashboard/players/forms/playerFormData.selector.js

Lines 17 to 38 in 6127344

	const getCurrTeams = createSelector(
	[getTeams, getSeasons],
	(teams, seasons) => {
	let activeSeasons = {};
	seasons.forEach(season => {
	if (season.active) {
	season.teams.forEach(team => {
	activeSeasons[team] = season._id;
	});
	}
	});
	return teams.reduce((arr, team) => {
	if (activeSeasons[team._id]) {
	team.seasonId = activeSeasons[team._id];
	arr.push(team);
	}
	return arr;
	}, []);
	}
	);

If you create a season, then add your team to it, the team dropdown includes the team as expected.

If we agree that this is reasonable behavior, maybe the best thing to do would be to add an error to the form if the teams prop is null explaining that you have to have a team and that team has to be in an active season.

[afranco07]

I agree with Ben and his solution. The team must be active and also part of a season to get it to show up in the drop down list.