New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wording for step 5 of pyramid project #54608
Comments
The note is correct. I think you are interpertering it wrong? It is saying edit: It is not saying that you can use any kind of keyword like |
Text refers to potential situation when both assignments are using let programmer = "Naomi";
let programmer = "CamperChan"; Depending on where exactly both are used, this can result in
There's no |
Hi @jmmarco, thank you for creating the issue. As Sem pointed out, we don't think the note should be updated to
because the new version communicates different information from the original. I think the confusion came from the word "declared". The word isn't needed since "reassigning" already implies that the variable has been declared, so I'd propose changing the sentence a little: --- Note that when reassigning a variable that has already been declared, you do **not** use the `let` keyword.
+++ Note that when reassigning a variable, you do **not** use the `let` keyword again. cc'ing @jdwilkin4 for input, since you're much more experienced with this kind of change than I am 😄 |
Thanks for the input @huyenltnguyen your proposal addresses the issue I presented👍 |
That change works for me. Note to contributorsThis has been opened for contribution. The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors. If you would like to contribute and have not read the contributors docs, please do so here: https://contribute.freecodecamp.org/#/ If you have any issues with contributing, be sure to join us on the contributors channel, or on the contributors sub-forum Files that need to be changedupdated descriptionWhen a variable is declared with the `let` keyword, you can <dfn>reassign</dfn> (or change the value of) that variable later on. In this example, the value of `programmer` is changed from `"Naomi"` to `"CamperChan"`.
```js
let programmer = "Naomi";
programmer = "CamperChan";
```
Note that when reassigning a variable, you do **not** use the `let` keyword again.
After your `console.log`, assign the value `"World"` to your `character` variable. Happy coding |
Describe the Issue
Currently on step number 5 there's a note that reads
As it stands this note is incorrect and unnecessary.
Affected Page
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-introductory-javascript-by-building-a-pyramid-generator/step-5
Your code
No code, just instructions re-wording.
Expected behavior
The note could be changed to:
Or we can simply remove it altogether instead.
Screenshots
System
Additional context
No response
The text was updated successfully, but these errors were encountered: