fix: test catch if function is empty #54597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
scope: curriculum
Dario-DC
added
the
status: waiting review
zairahira
requested changes
May 6, 2024
There was a problem hiding this comment.
This code still passes if variables are present outside:
import secrets
import string
# Define the possible characters for the password
letters = string.ascii_letters
digits = string.digits
symbols = string.punctuation
# Combine all characters
all_characters = letters + digits + symbols
def generate_password():
# Define the possible characters for the password
letters = string.ascii_letters
digits = string.digits
symbols = string.punctuation
# Combine all characters
all_characters = letters + digits + symbolsHere is the hint and test to fix this:
The four variable declarations shouldn't exist outside the function.
```js
({
test: () => assert.isFalse(runPython(`
_Node(_code).find_variable('letters').is_equivalent('letters = string.ascii_letters') and \\
_Node(_code).find_variable('digits').is_equivalent('digits = string.digits') and \\
_Node(_code).find_variable('symbols').is_equivalent('symbols = string.punctuation') and \\
_Node(_code).find_variable('all_characters').is_equivalent('all_characters = letters + digits + symbols')
`))
})
```
|
Yes, I am checking that the new function is defined correctly, which was the issue, not if the are extra pieces of code @zairahira also that test wouldn't work if you want to check that all the variables are not present, it needs to be with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
mainbranch of freeCodeCamp.Closes #54596