Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test in step 13 of Password Generator project not checking for function body content #54596

Closed
Dario-DC opened this issue May 1, 2024 · 0 comments · Fixed by #54597
Closed
Assignees
Labels
new python course scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: PR in works Work in Progress (WIP) Issues. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.

Comments

@Dario-DC
Copy link
Contributor

Dario-DC commented May 1, 2024

Describe the bug
Step 13 asks to declare a function and move the existing lines of code after the imports inside it. There's only one test that checks that the function exists. Therefore, one can pass this step declaring an empty function.

To Reproduce
Steps to reproduce the behavior:

  1. Go here
  2. Add def generate_password(): pass
  3. Run the tests

Expected behavior
def generate_password(): pass should not be enough to pass this step.
Another tests should check that the lines of code inside the editable region are inside the function body.

Additional context
ast-based helpers docs https://contribute.freecodecamp.org/#/curriculum-help?id=ast-based-helpers

@Dario-DC Dario-DC added type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc. help wanted Open for all. You do not need permission to work on these. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. new python course labels May 1, 2024
@ilenia-magoni ilenia-magoni self-assigned this May 1, 2024
@ilenia-magoni ilenia-magoni added status: PR in works Work in Progress (WIP) Issues. and removed help wanted Open for all. You do not need permission to work on these. labels May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new python course scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: PR in works Work in Progress (WIP) Issues. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants