Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change share on Twitter to share on X #54572

Open
moT01 opened this issue Apr 29, 2024 · 5 comments
Open

Change share on Twitter to share on X #54572

moT01 opened this issue Apr 29, 2024 · 5 comments
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: UI Threads for addressing UX changes and improvements to user interface status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.

Comments

@moT01
Copy link
Member

moT01 commented Apr 29, 2024

Describe the Issue

When viewing one of the certification you've earned, there's a "Share on Twitter" button. Wondering if we should change that to "Share on X"

Affected Page

https://www.freecodecamp.org/certification/your-username/responsive-web-design

@moT01 moT01 added type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc. status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. labels Apr 29, 2024
@moT01 moT01 changed the title Change share on Twitter to use X Change share on Twitter to share on X Apr 29, 2024
@a2937
Copy link
Member

a2937 commented Apr 29, 2024

I would only change it the day that website changes the URL to x.com fully from twitter.com. Despite the branding changing, it still seems to internally be referred to as Twitter. I mean maybe one day we'll have to , but for now it seems like a non-issue.

@juancaorg
Copy link
Contributor

I mean, I still prefer to call it Twitter and it still uses the twitter.com domain for almost everything relevant. However, the branding was indeed changed to "X".

It may be worth to change only the button text from "Share on Twitter" to "Share on X" as @moT01 suggests. And the icon too if it's used anywhere else (from the bird to the "X" icon).

image

Still looks odd to me, ngl.

@Asin-Junior-Honore
Copy link

i would like to work on this and make the requested changes @moT01

@a2937
Copy link
Member

a2937 commented May 4, 2024

Hi there,

Thanks for your interest in contributing.

This issue has not been triaged yet, and a solution has not been agreed upon. Once the issue is open for contribution, you are welcome to create a pull request to reflect the issue consensus. Please also note that we typically do not assign issues. Instead, we accept the first pull request that comprehensively solves the issue.

@gikf
Copy link
Member

gikf commented May 17, 2024

Looks like x.com started to be used more consistently. Including redirections twitter.com -> x.com.

@gikf gikf added scope: UI Threads for addressing UX changes and improvements to user interface platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: UI Threads for addressing UX changes and improvements to user interface status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.
Projects
None yet
Development

No branches or pull requests

5 participants