Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow additional support for multiple networks #49

Open
MitchTurner opened this issue Oct 1, 2022 · 0 comments
Open

Allow additional support for multiple networks #49

MitchTurner opened this issue Oct 1, 2022 · 0 comments
Labels
High Priority This should get worked on sooner than later

Comments

@MitchTurner
Copy link
Collaborator

There is limited support for using networks other than TESTNET currently. For example, the AlwaysSucceedsScript sample dApp's network is hard-coded, and it should be parameterized, or maybe the scripts shouldn't even worry about the network?

I think the easiest solution though is just adding a network(&self) -> u8 method to the LedgerClient trait. Then we don't need to worry about it and everyone has access to it that needs it.

Seems like a smell... A bit of a got type. But it's an easy solution for now.
@MitchTurner MitchTurner changed the title Allow additional support multiple networks Allow additional support for multiple networks Oct 1, 2022
@MitchTurner MitchTurner added the High Priority This should get worked on sooner than later label Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
High Priority This should get worked on sooner than later
Projects
Naumachia Triage
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MitchTurner