Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rig control button labels show the wrong action state, or "??" #11

Open
frazierjason opened this issue Jan 12, 2023 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@frazierjason
Copy link
Owner

frazierjason commented Jan 12, 2023

Describe the bug
After starting TouchPortal and connecting to my tablet, many of the radio adjustment buttons don't show any command status, they just end in a double question mark like "AGC ??". They don't get fixed until tapping on the button, and only after that do they show status like On/Off, High/Low, etc.

To Reproduce
Steps to reproduce the ?? button behavior:

  1. Restart N1MM+, restart TouchPortal for Windows, connect tablet to TouchPortal
  2. Go to the Radio Adjustment page for my rig
  3. Look at some of the radio adjustment buttons.
    BUG: The button action doesn't have to be CAT control, it can even just use keystrokes to tell N1MM+ to do stuff like Alt+Quote to toggle the radio filter between Narrow and Wide.

Steps to reproduce the wrong state behavior:

  1. Follow the steps above
  2. Now press a button, for example "Moni ??" and tap it until it says Moni On
  3. On the rig, directly change the Monitor feature to be off
  4. Now look at the TP button you were just pressing in step 2
    BUG: the button still says Moni On, even though it's actually off

Expected behavior
Show the real status, or tell me what the next state is if I touch the button

Screenshots
A cat

Desktop (please complete the following information):

  • OS: Win 10 Pro
  • Version: 21H2
  • TouchPortal app version: 3.1 build 8

Smartphone (please complete the following information):

  • Device: Google Nexus 7
  • OS: Android Lineage 17
  • TouchPortal store app Version: 3.1 build 2
  • Connection type to PC: WiFi

Additional context
Using ICOM IC-705 over USB CAT CI-V

@frazierjason frazierjason added the enhancement New feature or request label Jan 12, 2023
@frazierjason
Copy link
Owner Author

frazierjason commented Jan 12, 2023

This behavior is currently by design for nearly all buttons. Many sample buttons for radio adjustment rely on TP Value variables to store what state a button is considered to be cycled onto (toggle for two states, loop for multiple states). When TP first starts up, these values are not yet initialized.

In the interest of keeping the door open to future ability to fetch the real radio states for these, the radio adjustment button action samples were designed to start in the unknown state "??". On first touch of the button, it will repopulate to the first of the toggle/cycle of possibilities (On/Off, Fast/Medium/Slow, etc). You'll then see the new state that you've just now sent to the rig as a command. Keep tapping the button to send more commands and further change the desired radio feature.

If ways are discovered to reliably retrieve the current status of a feature, without unnecessarily encumbering N1MM+ or its developers/community, the plugin may be updated in the future to replace the question marks with the live real radio status, and track the actual state even if the radio is edited directly outside of TP/N1MM+.

The first button where an enhancement implementation can be tried is Mode (CW/SSB/RTTY), since we do get this data in N1MM+ RadioInfo messages over UDP. There isn't much more available to improve at this time.

@frazierjason frazierjason changed the title Rig control buttons start up with "??" label statuses Rig control button labels show the wrong action state, or "??" Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant