Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Sometimes model curve doesn't match the transit parameters #18

Closed
martindevora opened this issue Aug 4, 2020 · 3 comments
Closed

[BUG] Sometimes model curve doesn't match the transit parameters #18

martindevora opened this issue Aug 4, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@martindevora
Copy link
Collaborator

Example for TIC 299798795:
Run_1_PDCSAP-FLUX_MIS_TIC 299798795_all
tls_results.folded_phase[np.argwhere(tls_results.folded_phase_model < 1)]
This returns a range between 0.495 and 0.505 for the period of 4.17 which would be a duration of 60 mins aprox. However, the tls returned duration is 13 minutes.
Possible bug for transitleastsquares.
@franpoz
Copy link
Owner

franpoz commented Aug 4, 2020

We may export this issue directly to TLS package to know their opinion

@martindevora martindevora added the bug Something isn't working label Aug 8, 2020
@martindevora
Copy link
Collaborator Author

They already have one open: . I'm not closing this one because I will implement a fix for SHERLOCK.

@martindevora
Copy link
Collaborator Author

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@franpoz @martindevora