Remake console backend from JAX-RS to Spring-MVC #6755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or spring endpoints & remade SecurityItems endpoint in spring
FileViewer in spring does currently stream
…g-web-mvc' of https://github.com/frankframework/frankframework into issue/6676-migrate-console-backend-from-jax-rs-to-spring-web-mvc
…x-rs-to-spring-web-mvc
…nd-from-jax-rs-to-spring-web-mvc' into issue/6676-migrate-console-backend-from-jax-rs-to-spring-web-mvc
…g-web-mvc' of https://github.com/frankframework/frankframework into issue/6676-migrate-console-backend-from-jax-rs-to-spring-web-mvc
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+110
to
+111
| SEC_LOG.info("created bus request from URI [{}:{}] issued by{} with headers [{}] payload [{}]", method, base.getServletRequest() | ||
| .getRequestURI(), issuedBy, headers, payload); |
Check notice
Code scanning / SonarCloud
Logging should not be vulnerable to injection attacks
| if("GET".equalsIgnoreCase(method) || "OPTIONS".equalsIgnoreCase(method)) { | ||
| SEC_LOG.debug("created bus request from URI [{}:{}] issued by{}", method, base.getUriInfo().getRequestUri(), issuedBy); | ||
| if ("GET".equalsIgnoreCase(method) || "OPTIONS".equalsIgnoreCase(method)) { | ||
| SEC_LOG.debug("created bus request from URI [{}:{}] issued by{}", method, base.getServletRequest().getRequestURI(), issuedBy); |
Check notice
Code scanning / SonarCloud
Logging should not be vulnerable to injection attacks
| // This event listens to all Spring refresh events. | ||
| // When adding new Spring contexts (with this as a parent) refresh events originating from other contexts will also trigger this method. | ||
| // Since we never want to reinitialize this servlet, we can ignore the 'refresh' event completely! | ||
| super.doService(request, response); |
Check notice
Code scanning / SonarCloud
Exceptions should not be thrown from servlet methods
…nd-from-jax-rs-to-spring-web-mvc' into issue/6676-migrate-console-backend-from-jax-rs-to-spring-web-mvc
nielsm5
approved these changes
May 29, 2024
jkosternl
requested changes
May 30, 2024
console/backend/src/main/java/org/frankframework/management/web/ConfigurationStatus.java
Show resolved
Hide resolved
console/backend/src/main/java/org/frankframework/management/web/FrankApiBase.java
Outdated
Show resolved
Hide resolved
console/backend/src/main/java/org/frankframework/management/web/Init.java
Show resolved
Hide resolved
console/backend/src/main/java/org/frankframework/management/web/Monitors.java
Show resolved
Hide resolved
...nd/src/main/java/org/frankframework/management/web/configuration/DeprecationInterceptor.java
Show resolved
Hide resolved
|
|
||
| import org.springframework.web.filter.ShallowEtagHeaderFilter; | ||
|
|
||
| public class WeakShallowEtagHeaderFilter extends ShallowEtagHeaderFilter { |
There was a problem hiding this comment.
Adding this reason in this PR is nice, but won't be seen in the future. Please use Javadoc instead.
jkosternl
approved these changes
May 30, 2024
|
nielsm5
deleted the
issue/6676-migrate-console-backend-from-jax-rs-to-spring-web-mvc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.