Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cross compilation error : pq.Error does not implement error (method Error has pointer receiver) #681

Open
athoune opened this issue Feb 14, 2024 · 2 comments
Open

cross compilation error : pq.Error does not implement error (method Error has pointer receiver) #681

athoune opened this issue Feb 14, 2024 · 2 comments
Assignees
@foxcpp
Labels
bug Something isn't working. ready-for-release Feature is implemented and available for testing in dev branch. It will be included in the next rele

Comments

@athoune
Copy link

athoune commented Feb 14, 2024

Describe the bug

Cross compilation error. The error comes from go-imap-sql package.

Steps to reproduce

> git rev-parse --short HEAD
2da4ece
> go version
go version go1.21.7 darwin/amd64
> GOOS=linux GOARCH=arm64 ./build.sh
-- Version: 0.7.1+2da4ece
-- Building main server executable...
# github.com/foxcpp/go-imap-sql
/Users/mlecarme/go/pkg/mod/github.com/foxcpp/[email protected]/errors_noncgo.go:12:18: impossible type assertion: err.(pq.Error)
	pq.Error does not implement error (method Error has pointer receiver)

No error with native compilation. I guess with cross compilation less C stuff is used and the clue is *_noncgo.

Environment information

  • maddy version: 0.7.1
@athoune athoune added the bug Something isn't working. label Feb 14, 2024
foxcpp added a commit that referenced this issue Feb 14, 2024
@foxcpp
Bump go-imap-sql version
1d6cd8c 
See #681.
@foxcpp
Copy link
Owner

foxcpp commented Feb 14, 2024

Indeed, looks like I forgot to update non-CGo version of the file. Pushed 1d6cd8c to fix this.

@foxcpp foxcpp self-assigned this Feb 14, 2024
@athoune
Copy link
Author

athoune commented Feb 15, 2024

LGTM with 1d6cd8c

@foxcpp foxcpp added the ready-for-release Feature is implemented and available for testing in dev branch. It will be included in the next rele label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@foxcpp foxcpp

Labels
bug Something isn't working. ready-for-release Feature is implemented and available for testing in dev branch. It will be included in the next rele
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@athoune @foxcpp