Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One-Click Windows Version (cmd stays open after execution) #63

Open
auslaender6 opened this issue Dec 21, 2021 · 3 comments
Open

One-Click Windows Version (cmd stays open after execution) #63

auslaender6 opened this issue Dec 21, 2021 · 3 comments

Comments

@auslaender6
Copy link

auslaender6 commented Dec 21, 2021

Hi,
would it be possible to let the cmd stay open if users just double-click the exe? It will be usefull for non IT-people just to click, instead of open a cmd and start the *.exe form there :).

Like here:
vercel/pkg#644

We would link this (fantastic tool) and gave that link to our end users for home use. Most of them are non IT-people.

cheers
Niko

@PaulHoving
Copy link

And also the executable should be signed then. I do not want to tell users to ignore warnings. (Especially non-it people)

@sibalzer
Copy link

sibalzer commented Dec 21, 2021

A simple batch script should do the trick:
start-finder.bat

log4j-finder.exe
pause

Otherwise you can add these lines to the .py and build the exe yourself.

if __name__ == "__main__":
    ...
    if sys.platform == "win32":
        os.system("pause")

@yunzheng
Copy link
Member

And also the executable should be signed then. I do not want to tell users to ignore warnings. (Especially non-it people)

we have now signed the v1.2.0 windows executable, attached to the v1.20 release page:

https://github.com/fox-it/log4j-finder/releases/download/v1.2.0/log4j-finder-windows-signed-v1.2.0.zip
https://github.com/fox-it/log4j-finder/releases/download/v1.2.0/log4j-finder-signed.exe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants