Document that cheats that do not call the cheatcode address are still executed after a `vm.expectRevert` #948

PaulRBerg · 2023-07-07T09:23:11Z

Ref:

IaroslavMazur · 2023-07-07T09:49:23Z

@mds1's way of phrasing what should appear on the documentation page sounds the most suggestive, in my opinion:

"the book is trying to say "calls to other cheatcodes are not counted as 'the next call' when expecting a revert, and are ignored in that sense, but the cheatcode otherwise behaves normally", but it's not very clear"

PaulRBerg mentioned this issue Jul 7, 2023

Changes in test/ resulting from the audit PaulRBerg/prb-proxy#145

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Document that cheats that do not call the cheatcode address are still executed after a `vm.expectRevert` #948

Document that cheats that do not call the cheatcode address are still executed after a `vm.expectRevert` #948

PaulRBerg commented Jul 7, 2023 •

edited

IaroslavMazur commented Jul 7, 2023

Document that cheats that do not call the cheatcode address are still executed after a vm.expectRevert #948

Document that cheats that do not call the cheatcode address are still executed after a vm.expectRevert #948

Comments

PaulRBerg commented Jul 7, 2023 • edited

IaroslavMazur commented Jul 7, 2023

Document that cheats that do not call the cheatcode address are still executed after a `vm.expectRevert` #948

Document that cheats that do not call the cheatcode address are still executed after a `vm.expectRevert` #948

PaulRBerg commented Jul 7, 2023 •

edited