Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies of new packages by web UI #12

Open
henilp105 opened this issue Jan 3, 2023 · 3 comments
Open

Dependencies of new packages by web UI #12

henilp105 opened this issue Jan 3, 2023 · 3 comments

Comments

@henilp105
Copy link
Member

I have considered the following options for the addition of dependencies of packages to its document in packages collection :

  1. Read the following from toml file.
  2. User enters the packages in csv manner.
  3. Add a dropdown to add the packages, by searching and selecting packages.

In my opinion it is generally better to add a dropdown or directly get them from the toml file of the packages.
I would like to request all the Community members to review and add suggestions.

Thanks and Regards,
Henil

CC @awvwgk @fortran-lang/admins @fortran-lang/fpm @arteevraina @perazz @minhqdao

@perazz
Copy link

perazz commented Jan 3, 2023

IMHO dependencies are the most important descriptor of a package besides the source code itself, so I would lean on keeping everything consistent to what’s in the package toml file.

Down the road we will need mechanisms for version resolution and comparison for each dependency, which I think we need to define at the toml level too (e.g. v1.1.0 or v1.2.3 or (v>=2.0.0 and v<3.0.0)

@arteevraina
Copy link
Member

IMHO dependencies are the most important descriptor of a package besides the source code itself, so I would lean on keeping everything consistent to what’s in the package toml file.

Down the road we will need mechanisms for version resolution and comparison for each dependency, which I think we need to define at the toml level too (e.g. v1.1.0 or v1.2.3 or (v>=2.0.0 and v<3.0.0)

Agreed. I think it's better and more consistent to parse the toml file and parse the dependencies from there. But, then the other question is Are we going to allow user to upload the toml file of their project and then we can parse it in the backend ?

@henilp105
Copy link
Member Author

@arteevraina yes, we would allow the user to upload the entire package as we also have to implement the package upload restrictions and checks so, we would take the entire package and then parse the toml .

arteevraina pushed a commit to arteevraina/registry that referenced this issue Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants