Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pro Slider show-input inputs not reactive #1341

Closed
leemartin opened this issue May 4, 2024 · 2 comments
Closed

Pro Slider show-input inputs not reactive #1341

leemartin opened this issue May 4, 2024 · 2 comments
Assignees
Labels
🐛 bug Verified bug by team 🟡 priority-2 2. Medium priority issue Pro Pertains to FormKit Pro 🚀 release-ready Feature or fix is complete and on an upcoming release branch

Comments

@leemartin
Copy link

leemartin commented May 4, 2024

Reproduction

https://formkit.link/65550963434f345c48d27195c8d17b7a

Describe the bug

I'm attempting to use the Pro Slider input as a way for users to be able to trim audio files. In order to do this, the user selects an audio file and I get the file's duration. I then pass that duration back to the Pro slider input as a new dynamic max value. In addition, I have written a custom rule called duration which makes sure the difference of the multiple values (start/end) are less than a max duration I specify. (In the case of this reproduction, 30 seconds.) If you click the "change" button, I use a ref element to reactively update the max prop of the Slider input. In order to reproduce the issue, first click the "Change" button to simulate a max prop change from the default of 60 to 360. You must then select a portion of the track beyond the the 60 second mark. Finally, click submit on the form and you'll see the input warning on the show-input field. If you look at the output code of the FormKit Playground, you'll see that the show-input fields max props are not updating with the reactive element. This is also the case for dynamically changing the disabled prop and I'd suspect other props. I posted about this on the forum with videos here:

https://discord.com/channels/793529058377072650/1233787079247528056/1233787079247528056

Any help is much appreciated!

Environment

• OS: macOS, iOS
• Browser Chrome, Safari

@leemartin leemartin added ⛑ Needs triage The issue has not yet been examined by the FormKit team. 🐛 bug-report Bug is reported, but not verified by team labels May 4, 2024
@leemartin
Copy link
Author

I should mention that, for now, I am using it without the show-input and it works fine.

@andrew-boyd andrew-boyd added 🐛 bug Verified bug by team 🟡 priority-2 2. Medium priority issue Pro Pertains to FormKit Pro and removed 🐛 bug-report Bug is reported, but not verified by team ⛑ Needs triage The issue has not yet been examined by the FormKit team. labels May 9, 2024
@andrew-boyd
Copy link
Member

@andrew-boyd andrew-boyd added the 🚀 release-ready Feature or fix is complete and on an upcoming release branch label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Verified bug by team 🟡 priority-2 2. Medium priority issue Pro Pertains to FormKit Pro 🚀 release-ready Feature or fix is complete and on an upcoming release branch
Projects
None yet
Development

No branches or pull requests

2 participants