Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: changes misleading download button #2582

Closed
wants to merge 1 commit into from
Closed

fix: changes misleading download button #2582

wants to merge 1 commit into from

Conversation

AprajitKatiyar
Copy link

@AprajitKatiyar AprajitKatiyar commented May 6, 2024 •
edited

What does this PR do?

Fixes #2526

Removed the misleading download button action and added a better icon.

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 馃檹

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

@vercel Vercel
Copy link

vercel bot commented May 6, 2024

@aprajit99 is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented May 6, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the enhancement New feature or request label May 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024 •
edited

Thank you for following the naming conventions for pull request titles! 馃檹

@AprajitKatiyar AprajitKatiyar mentioned this pull request May 6, 2024
Open
@mattinannt mattinannt requested a review from jobenjada May 7, 2024 07:52
@jobenjada
Copy link
Member

hey @AprajitKatiyar - thanks for your suggestion, but we're merging the other PR since it was opened first 馃

@jobenjada jobenjada closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jobenjada jobenjada Awaiting requested review from jobenjada

Assignees

@jobenjada jobenjada

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] Download button has misleading icon
3 participants
@AprajitKatiyar @CLAassistant @jobenjada