Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Class Name Conflicts #2486

Open
2 tasks
jonas-hoebenreich opened this issue Apr 18, 2024 · 0 comments
Open
2 tasks

[BUG] Class Name Conflicts #2486

jonas-hoebenreich opened this issue Apr 18, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jonas-hoebenreich
Copy link
Contributor

jonas-hoebenreich commented Apr 18, 2024

Issue Summary

Currently, website surveys are displayed incorrectly on websites that inadvertently overwrite tailwind classes.
Suppose developer Dave has added an element that uses the following CSS:

.border {
    position:absolute;
    left: 0;
    width:100%;
    height:1px;
    background-color: gray;
}

As the survey modal also uses the "border" class, this CSS is now also applied to the survey, making the survey completely unusable.

Steps to Reproduce

  1. Try to display a survey on a page that has the following CSS:
.border {
    position:absolute;
    left: 0;
    width:100%;
    height:1px;
    background-color: gray;
}
  1. Survey is not usable

Expected behavior

Surveys look nice on all types of websites (regardless of other CSS on that page).

Solution:
Formbricks should encapsulate the survey from the rest of the page. And / or it should not use common class names ("border" etc.) by eg adding a prefix to the classes to make collisions less likely.

Other information

No response

Screenshots

No response

Environment

  • Formbricks Cloud (app.formbricks.com)
  • Self-hosted Formbricks

Desktop (please complete the following information)

- OS:
- Node:
- npm:
@jonas-hoebenreich jonas-hoebenreich added the bug Something isn't working label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant