Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Won’t start if npmjs is not reachable #2435

Open
1 of 2 tasks
mark-kubacki opened this issue Apr 12, 2024 · 6 comments
Open
1 of 2 tasks

[BUG] Won’t start if npmjs is not reachable #2435

mark-kubacki opened this issue Apr 12, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@mark-kubacki
Copy link

Issue Summary

Using the container image, Formbricks App won’t start when npmjs is not reachable.

Steps to Reproduce

  1. Follow the tutorial for use with docker-compose: https://formbricks.com/docs/self-hosting/docker
  2. … but stop short of bringing the pod up.
  3. Disconnect from the internet. (For example, because you work offline, in an segmented local network, an ad-hoc network with people in the room, or behind a restrictive corporate firewall.)
  4. docker compose up

Expected behavior

The container images should come with everything needed, i.e. no outside dependencies yet to be loaded.

  • No container gets restarted.
  • The formbricks setup works.

Other information

No response

Screenshots

docker compose up

image

Environment

  • Formbricks Cloud (app.formbricks.com)
  • Self-hosted Formbricks

Desktop (please complete the following information)

(self-hosted using Docker)
@mark-kubacki mark-kubacki added the bug Something isn't working label Apr 12, 2024
Copy link
Contributor

Thank you for opening your first issue! 🙏❤️ One of our team members will review it and get back to you as soon as it possible. 😊

@mattinannt
Copy link
Member

@mark-kubacki thanks for opening the ticket :-) We already solved this in the current main branch in this will get included in the next release :-)
I'm not sure if this was already part of the last release; are you on Formbricks 1.6.1?

@mark-kubacki
Copy link
Author

mark-kubacki commented Apr 12, 2024

I’m at whatever is the latest according the docker-compose config I’ve downloaded today. :-)
Unfortunately it pulls ghcr.io/formbricks/formbricks:latest and that’s not annotated.

Let me regenerate the container image real quick, assuming that’s how you’d do it:

git clone --single-branch \
  --recurse-submodules \
  --filter=blob:none --also-filter-submodules \
  "https://github.com/formbricks/formbricks.git" fb-repo
cd $_

docker build \
  -t "ghcr.io/formbricks/formbricks:latest" \
  -f apps/web/Dockerfile \
  .

Update: Nope, no luck:

image

@mattinannt
Copy link
Member

mattinannt commented Apr 15, 2024

@mark-kubacki You need an internet connection to build the image. But for starting the container you don't need an internet connection anymore 😊
The latest tag will be updated as soon as we make the next release. Unfortunately since we are currently facing some issues with the @formbricks/js integration that we need to sort out first, I can't give you a release date for this.

@mark-kubacki
Copy link
Author

mark-kubacki commented Apr 15, 2024

Please point me to your scripts that build the container image, for my attempts and above command, now that the site is reachable, remain unsuccessful:
image

Separately I’d propose introducing annotations.
https://specs.opencontainers.org/image-spec/annotations/?v=v1.0.1

v1.6.1 is annotated, I’ve just learned. I let the Dockerfile mislead me.

@mark-kubacki
Copy link
Author

mark-kubacki commented Apr 15, 2024

I’ve rebuilt the image from 31e5959 ($(git rev-list -1 --before "2024-04-15 11:29" main) when writing above comment) and found that it still relies on external services on start.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants