-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of "name eq .*#{identity}" logic #404
Comments
If not needed anymore, let's remove it. I hadn't realized it changed, what's the difference that makes it not needed? |
@icco So AFAIK the resources in The problem of changing it to |
This issue has been marked inactive and will be closed if no further activity occurs. |
So, if I'm reading it right the "name eq .*#{identity}" logic is not needed anymore.
I'm talking about the "Servers" for example:
fog-google/lib/fog/compute/google/models/servers.rb
Lines 34 to 38 in 8780575
I think we shouldn't append the
.*
to the filter (which used to be important when selecting by self-links, but not anymore) and let users set their own regex if they choose to.This will also get rid of #33
This is a breaking change so setting to milestone
2.0
@icco WDYT?
The text was updated successfully, but these errors were encountered: