Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectmenu still displayed when a dialog is closed with "escape" key #296

Open
donino opened this issue Apr 3, 2013 · 4 comments
Open

Comments

@donino
Copy link

donino commented Apr 3, 2013

Hi,

I use a selectmenu widget 1.4.0pre embedded in a jquery UI 1.10.2 dialog. If we close this dialog with escape key when the selectmenu is not collapsed, then the selection list is still displayed, floating on the screen until the user clicks anywhere.

This issue can be reproduced with any browser

Thanks

@fnagel
Copy link
Owner

fnagel commented Apr 3, 2013

If you need a version working with the latest jQuery / UI you should test
the jQuery UI Selectmenu branch:
https://github.com/jquery/jquery-ui/tree/selectmenu
It will (hopefully) released with UI 1.11.0

@donino
Copy link
Author

donino commented Apr 4, 2013

Thank you for the fast response Felix. I have just tried this version but it seems there is a dependency on a future method of the menu widget, i got "uncaught Error: no such method 'instance' for menu widget instance". So i couldn't check if it is fixed in this branch.

Never mind, selectmenu 1.4pre works already very well with jQuery UI 1.10.2, except this minor issue with the escape key in a modal dialog. I just wanted to log it to be sure it could be taken in consideration in a next version

Best regards

@fnagel
Copy link
Owner

fnagel commented Apr 4, 2013

Thanks for your feedback! Please checkout this commit, it should work with
1.10.2:
jquery@5a9a80f

Sadly I'm not quite sure if I will update this branch if the official
versionis releases. I think this will be maintained as a legacy version
with support for earlier jQuery UI versions.
I will tag this issue and perhaps we'll find a solution. If you are able to
provide a tested patch, I will gladly intergrate it!

@fnagel fnagel closed this as completed Sep 7, 2013
@fnagel fnagel reopened this Sep 7, 2013
@fnagel
Copy link
Owner

fnagel commented Sep 30, 2014

Is this issue still valid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants