Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Edit this page links are not working for Flyte Documentation #4109

Open
2 tasks done
Tracked by #4064
Smartmind12 opened this issue Oct 1, 2023 · 12 comments · May be fixed by flyteorg/flytesnacks#1200
Open
2 tasks done
Tracked by #4064

[BUG] Edit this page links are not working for Flyte Documentation #4109

Smartmind12 opened this issue Oct 1, 2023 · 12 comments · May be fixed by flyteorg/flytesnacks#1200
Assignees
@Smartmind12
Labels
bug Something isn't working hacktoberfest

Comments

@Smartmind12
Copy link
Contributor

Describe the bug

The "Edit this page" icon is not working as on clicking it takes you to a "File not found folder" instead of taking you to the correct path of the file. This invalid links has been enconuntered for many of the pages in the Flyte Documentation.

Expected behavior

The correct behaviour is that when a user clicks on the "Edit the Page" Pencil icon, then the user is taken to the correct repository in the github environment to edit/contribute changes to the documentation.

Additional context to reproduce

No response

Screenshots

Screenshot 2023-10-01 at 1 11 25 PM

Screenshot 2023-10-01 at 1 11 39 PM

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@Smartmind12 Smartmind12 added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Oct 1, 2023
@welcome
Copy link

welcome bot commented Oct 1, 2023

Thank you for opening your first issue here! 🛠

@Smartmind12
Copy link
Contributor Author

@samhita-alla Could you please assign it to me so that i can work on it!

@samhita-alla samhita-alla mentioned this issue Oct 2, 2023
Open
45 tasks
@itssiddhantjain
Copy link

Hello @samhita-alla, please assign this issue to me as I have already worked on this kind of problem in past and has a great experience.

@Smartmind12
Copy link
Contributor Author

Hello @samhita-alla, please assign this issue to me as I have already worked on this kind of problem in past and has a great experience.

@itssiddhantjain I am currently working on this issue ans will add a PR to close the same. Kindly work on another issue!

@Smartmind12
Copy link
Contributor Author

Smartmind12 commented Oct 2, 2023 •
edited

Hello @samhita-alla, please assign this issue to me as I have already worked on this kind of problem in past and has a great experience.

@itssiddhantjain I am currently working on this issue ans will add a PR to close the same. Kindly work on another issue!

It totally depends on @samhita-alla , also this is open source so many people can contribute. I hope you can understand mate.

@itssiddhantjain Mate she has already assigned the issue to me and like i have already stated earlier that i am working on it...so please find another issue to work on and not spam messages on a already assigned issue!

@prithvi2k2
Copy link

prithvi2k2 commented Oct 4, 2023 •
edited

@itssiddhantjain Open-source contributions are mainly about collaboration, not about fighting for issues. You can always open a new issue if you've found any or contribute to the ones which are not yet assigned to anyone. It's clearly seen that OP wants to fix a bug he discovered and also is assigned to do the same. Multiple people can be assigned if it's a bigger issue or PR which requires many to collaborate. I hope you understand mate.

@eapolinario eapolinario removed the untriaged This issues has not yet been looked at by the Maintainers label Oct 5, 2023
@samhita-alla
Copy link
Contributor

samhita-alla commented Oct 16, 2023 •
edited

@Smartmind12, are you working on creating a PR for this issue?

@Smartmind12
Copy link
Contributor Author

@Smartmind12, are you working on creating a PR for this issue?

Heyy @samhita-alla i have been busy but i will surely complete it with tomorrow or max day after!

@itssiddhantjain
Copy link

@samhita-alla I have also done this, can I send a PR if possible?

@Smartmind12
Copy link
Contributor Author

Smartmind12 commented Oct 16, 2023 •
edited

@samhita-alla I am trying to spin up the docs website on gitpod however the website is not spinning up so can you provide me the code to run the website locally?
Please help me in this so that i can test my code before making a PR!

@davidmirror-ops
Copy link
Contributor

@Smartmind12 you should be able to run the website locally by 1. pip install docs-requirements.txt on a venv with Python < 3.11 and 2. make -C /rsts HTML. The contribution guide needs to be updated with better instructions to do so, but these steps are what I follow to test the code when contributing to docs

@Smartmind12
Copy link
Contributor Author

@Smartmind12 you should be able to run the website locally by 1. pip install docs-requirements.txt on a venv with Python < 3.11 and 2. make -C /rsts HTML. The contribution guide needs to be updated with better instructions to do so, but these steps are what I follow to test the code when contributing to docs

Thanks for the help… i will try the same and let you know!

@Smartmind12 Smartmind12 linked a pull request Oct 21, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Smartmind12 Smartmind12

Labels
bug Something isn't working hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rearrangement and Toctree updates Smartmind12/flytesnacks
6 participants
@eapolinario @samhita-alla @prithvi2k2 @davidmirror-ops @Smartmind12 @itssiddhantjain