[Core feature] Flytekit create automatic bindings for Task default values #5321

kumare3 · 2024-05-03T05:00:16Z

Motivation: Why do you think this is important?

Currently this will not work, as rotation is not provided

@task(cache=True, cache_version="1")
def rotate_image(img: FlyteFile, rotation: int = 180) -> FlyteFile:
    img.download()
    with Image.open(img.path) as im:
        rotated = im.rotate(rotation)
        rotated.save("/tmp/rotated.jpeg")
    return FlyteFile("/tmp/rotated.jpeg")


@workflow
def wf(img: FlyteFile = "testdir/maradona.jpeg") -> FlyteFile:
    return rotate_image(img=img)

Goal: What should the final outcome look like, ideally?

Ideally we should automatically create a node binding in the workflow where the default value in the task inputs should be added to the node in the workflow

Describe alternatives you've considered

NA

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

Yes

Have you read the Code of Conduct?

Yes

Tasks

Give feedback

No tasks being tracked yet.

Options

Future-Outlier · 2024-05-03T05:00:36Z

Will start it after 5/12, thank you

runllm · 2024-05-03T05:00:45Z

The issue you're describing relates to the current limitation in Flyte where default values for task inputs are not automatically recognized and used in workflows. This is a known limitation, as discussed in GitHub issue #2426, where the Flyte type system does not automatically bind default values or None for optional variables unless explicitly provided. This behavior is intentional to ensure explicitness in workflow definitions.

Your proposed feature to automatically create node bindings for default task input values in workflows would require changes to the FlyteIDL and the core handling of task and workflow interfaces. This feature could simplify workflow definitions by reducing the need for explicit default value bindings at the workflow level, aligning task behavior more closely with standard Python function behavior.

Would you like more detail on how this could be implemented or the current discussions around this feature?

Sources:

This is an AI-generated response and your feedback is appreciated! Please leave a 👍 if this is helpful and 👎 if it is not.

Mention @RunLLM to ask follow-up questions. See runllm.com for more!

MortalHappiness · 2024-05-03T05:21:09Z

#take

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

flyteorg/flyte#5321 if the key is not in `kwargs` but in `interface.inputs_with_defaults`, add the value in `interface.inputs_with_defaults` to `kwargs`. Signed-off-by: Chi-Sheng Liu <[email protected]>

kumare3 added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels May 3, 2024

Future-Outlier self-assigned this May 3, 2024

github-actions bot assigned MortalHappiness May 3, 2024

Future-Outlier assigned MortalHappiness and unassigned MortalHappiness and Future-Outlier May 3, 2024

wild-endeavor added backlogged For internal use. Reserved for contributor team workflow. flytekit FlyteKit Python related issue and removed untriaged This issues has not yet been looked at by the Maintainers labels May 9, 2024

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue May 9, 2024

feat(bindings): Task arguments default value binding

b434ddf

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness mentioned this issue May 9, 2024

feat(bindings): Task arguments default value binding flyteorg/flytekit#2401

Merged

3 tasks

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue May 9, 2024

feat(bindings): Task arguments default value binding

cc13415

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue May 15, 2024

feat(bindings): Task arguments default value binding

ae3a7c7

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue May 15, 2024

chore: Delete redundant lines

277d88b

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue May 15, 2024

feat(bindings): Task arguments default value binding

5be12cd

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue May 15, 2024

chore: Delete redundant lines

51e15e5

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue May 16, 2024

feat(bindings): Task arguments default value binding

49f8c27

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue May 16, 2024

chore: Delete redundant lines

6446ad1

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue May 17, 2024

feat(bindings): Task arguments default value binding

deb4924

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue May 17, 2024

chore: Delete redundant lines

6c808ae

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue May 25, 2024

feat(bindings): Task arguments default value binding

0a71009

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue May 25, 2024

chore: Delete redundant lines

db89a06

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue May 25, 2024

test(default-args): Add more tests according to Yee's recommendation

6042fcf

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue May 25, 2024

test(default-args): Add more tests according to Yee's recommendation

df966a2

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue May 25, 2024

feat(bindings): Task arguments default value binding

1f8934c

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue May 25, 2024

chore: Delete redundant lines

cb7d72e

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue May 25, 2024

test(default-args): Add more tests according to Yee's recommendation

463e30b

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue May 25, 2024

test(default-args): Add more tests according to Yee's recommendation

ef40c59

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue May 26, 2024

test(default-args): Add more tests according to Yee's recommendation

dd85acb

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue May 26, 2024

test(default-args): Add more tests according to Yee's recommendation

545adbc

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue May 26, 2024

test(default-args): Add more tests according to Yee's recommendation

d9a7345

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue May 29, 2024

feat(bindings): Task arguments default value binding

d69b6af

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue May 29, 2024

chore: Delete redundant lines

b429b2b

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue May 29, 2024

test(default-args): Add more tests according to Yee's recommendation

c90ce87

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue May 29, 2024

test(default-args): Add more tests according to Yee's recommendation

2de588f

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue Jun 4, 2024

feat(bindings): Task arguments default value binding

6c19346

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue Jun 4, 2024

chore: Delete redundant lines

ab9e6a6

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue Jun 4, 2024

test(default-args): Add more tests according to Yee's recommendation

a0e679c

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue Jun 4, 2024

feat(bindings): Don't expand union type if default arg is used

c9cb9df

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

wild-endeavor mentioned this issue Jun 4, 2024

Add escape for scalars to binding during union handling flyteorg/flytekit#2460

Merged

3 tasks

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue Jun 6, 2024

feat(bindings): Task arguments default value binding

ac1b026

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue Jun 6, 2024

chore: Delete redundant lines

7279f33

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue Jun 6, 2024

test(default-args): Add more tests according to Yee's recommendation

51a97d3

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue Jun 6, 2024

feat(bindings): Don't expand union type if default arg is used

b45a2aa

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

MortalHappiness added a commit to MortalHappiness/flytekit that referenced this issue Jun 6, 2024

fix(bindings): Update according to PR flyteorg#2460

b92519a

Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <[email protected]>

wild-endeavor closed this as completed in flyteorg/flytekit#2401 Jun 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Core feature] Flytekit create automatic bindings for Task default values #5321

[Core feature] Flytekit create automatic bindings for Task default values #5321

kumare3 commented May 3, 2024 •

edited by eapolinario

Tasks

Future-Outlier commented May 3, 2024

runllm bot commented May 3, 2024

MortalHappiness commented May 3, 2024

[Core feature] Flytekit create automatic bindings for Task default values #5321

[Core feature] Flytekit create automatic bindings for Task default values #5321

Comments

kumare3 commented May 3, 2024 • edited by eapolinario

Motivation: Why do you think this is important?

Goal: What should the final outcome look like, ideally?

Describe alternatives you've considered

Propose: Link/Inline OR Additional context

Are you sure this issue hasn't been raised already?

Have you read the Code of Conduct?

Tasks

Future-Outlier commented May 3, 2024

runllm bot commented May 3, 2024

MortalHappiness commented May 3, 2024

kumare3 commented May 3, 2024 •

edited by eapolinario