Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many open Pull Requests / still any development? #277

Closed
mschlenstedt opened this issue Jul 7, 2022 · 8 comments
Closed

Many open Pull Requests / still any development? #277

mschlenstedt opened this issue Jul 7, 2022 · 8 comments

Comments

@mschlenstedt
Copy link
Contributor

Hi,

there were a lot fixed bugs in develop comparing to 2.2.6. Still there are 11 open Pull Requests which also fixes a lot bugs. Is there any further development? Would be happy if there will be a bugfix release soon.

Can help if help is needed.

@flyte
Copy link
Owner

flyte commented Jul 7, 2022

Hi @mschlenstedt

Yes, I'm afraid I've been neglecting this project. Unfortunately I don't have time to dedicate to it and I've been burying my head in the sand to avoid the shame of officially announcing that I've abandoned a project that I'm quite proud of!

I actually made a large number of fixes and improvements on the https://github.com/flyte/mqtt-io/tree/feature/trio branch, but I got stuck trying to work out a good way to refactor/rebuild the tests, since they were too tightly coupled with the previous asyncio implementation.

Now we're in a state where there are a lot of PRs and issues for the 'released' version, which almost certainly don't apply to the feature/trio version, which is "better enough" that I didn't want to continue work on the 'released' version.

Help is certainly welcome. Please have a look at the feature/trio branch, which I consider to be a vast improvement over my implementation using asyncio.

I'm happy to spend some time on discord or wherever, in order to try to tidy things up a bit and help onboard people to get involved. To be honest, if other people are happy to collaborate, then I'd probably be more inclined to make time for writing code too.

@mschlenstedt
Copy link
Contributor Author

Hey @flyte !

Thanks for the qick answer. Even if it makes me not happy :-), I can fully understand. I also have too many projects I am working on ;-)

Maybe it is worth to make one last bugfix version 2.2.7 from the develop branch including the open PR. There are some severe bugs in the raspberry module and also in the pcf8574/5 modules which makes both more or less useless at the moment:

#268
19cf1e6
1e410dc

This is maybe "quickly done" and result would be a really good and reliable piece of software. After that we (and hopefully some others, too ;-)) can focus on the trio branch.

@flyte
Copy link
Owner

flyte commented Jul 7, 2022

I've merged that and I'm just struggling with the cobwebs on the release process now...

@flyte
Copy link
Owner

flyte commented Jul 7, 2022

2.2.7 should be on PyPI now.

@mschlenstedt
Copy link
Contributor Author

Great! Thanks!

@geccko

This comment was marked as off-topic.

@mschlenstedt
Copy link
Contributor Author

@geccko Please open a separate issue here.

@geccko
Copy link

geccko commented Jul 8, 2022

ok! Thanks!

@BenjiU BenjiU closed this as completed Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants