Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API package go.mod requests go 1.19 #1204

Open
ilithanos opened this issue Feb 27, 2024 · 0 comments
Open

API package go.mod requests go 1.19 #1204

ilithanos opened this issue Feb 27, 2024 · 0 comments

Comments

@ilithanos
Copy link
Collaborator

Not sure if this is intended or not but:

module github.com/weaveworks/tf-controller/api

go 1.19

And since the documentation states go1.20.x this could create issues.

This results in the ´make test´ target failing if run with 1.20 due to the api package failing, and if run with 1.19 due to the rest of the code failing.

Result when run with go1.20:

/bin/gen-crd-api-reference-docs -api-dir=./api/v1alpha2 -config=./hack/api-docs/config.json -template-dir=./hack/api-docs/template -out-file=./docs/References/terraform.md
I0227 14:42:35.369371    4068 main.go:129] parsing go packages in directory ./api/v1alpha2
I0227 14:42:35.391249    4068 main.go:231] using package=./api/v1alpha2
F0227 14:42:35.410392    4068 main.go:503] type invalid type has kind=Unsupported which is unhandled

Seems like the way this is run in pipelines vs the results i'm getting locally are different. Havn't found the exact difference yet though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant