Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new gallery benchmark throwing late initialization and potentially other errors #148548

Closed
zanderso opened this issue May 17, 2024 · 6 comments
Closed

new gallery benchmark throwing late initialization and potentially other errors #148548

zanderso opened this issue May 17, 2024 · 6 comments

Comments

@zanderso
Copy link
Member

Search for LateInitializationError in:

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8747679430480882145/+/u/run_new_gallery__transition_perf/stdout

and

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8747679038401611905/+/u/run_new_gallery_ios__transition_perf/stdout

Tagging @jonahwilliams first to ask if this is something to worry about, or something benign that wouldn't affect performance/correctness.
@jonahwilliams
Copy link
Member

not good!

@zanderso
Copy link
Member Author

It looks like this was probably introduced by #147793.

@zanderso zanderso mentioned this issue May 17, 2024
Merged
@zanderso
Copy link
Member Author

cc @nate-thegrate

zanderso added a commit that referenced this issue May 17, 2024
@zanderso
Revert "if chains → switch expressions" (#148556)
597462a 
Reverts #147793

Introduced #148548.
@nate-thegrate
Copy link
Member

Thanks for catching this!

@zanderso
Copy link
Member Author

This no longer happens after the revert. Closing.

@nate-thegrate nate-thegrate mentioned this issue May 19, 2024
Merged
auto-submit bot pushed a commit that referenced this issue May 20, 2024
@nate-thegrate
Reland "if chains → switch expressions" (#148634)
73ecc8a 
I did a goof a while back:

![late initialization error](https://github.com/flutter/flutter/assets/10457200/47dc423f-0dd0-4869-9a11-59cb7d1ea46e)

Now that [the bug is fixed](e9d4035), I think we're good to re-implement the if-chains cleanup!

Related:

- #147793
- #148556
- #148548
@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zanderso @jonahwilliams @nate-thegrate