Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InkWell highlight not working inside PageView on mobile platform. #147859

Open
indeedshaw opened this issue May 6, 2024 · 8 comments
Open

InkWell highlight not working inside PageView on mobile platform. #147859

indeedshaw opened this issue May 6, 2024 · 8 comments
Labels
f: material design flutter/packages/flutter/material repository. found in release: 3.19 Found to occur in 3.19 found in release: 3.22 Found to occur in 3.22 framework flutter/packages/flutter repository. See also f: labels. has reproducible steps The issue has been confirmed reproducible and is ready to work on P3 Issues that are less important to the Flutter project team-design Owned by Design Languages team triaged-design Triaged by Design Languages team

Comments

@indeedshaw
Copy link

indeedshaw commented May 6, 2024

Steps to reproduce

On Android 13
1.Use InkWell as the child of a PageView.
2.Tap InkWell Widget.

Expected results

Highlight working!

Actual results

InkHighlight does not draw.

Code sample

Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
        appBar: AppBar(
          backgroundColor: Theme.of(context).colorScheme.inversePrimary,
          title: Text(widget.title),
        ),
        body: Center(
          child: Column(
            mainAxisAlignment: MainAxisAlignment.center,
            children: <Widget>[
              // 1.working
              InkWell(
                onTap: () {},
                splashFactory: NoSplash.splashFactory,
                overlayColor: MaterialStateProperty.all(Colors.red),
                child: const Text(
                  'Test InkWell',
                  style: TextStyle(color: Colors.black, fontSize: 16),
                ),
              ),
              SizedBox(
                height: 200,
                // 2.not working
                child: PageView(
                  children: <Widget>[
                    Center(
                      child: InkWell(
                        onTap: () {},
                        splashFactory: NoSplash.splashFactory,
                        overlayColor: MaterialStateProperty.all(Colors.red),
                        child: const Text(
                          'PageView InkWell1',
                          style: TextStyle(color: Colors.black, fontSize: 16),
                        ),
                      ),
                    ),
                    Center(
                      child: InkWell(
                        onTap: () {},
                        child: const Text(
                          'PageView InkWell2',
                          style: TextStyle(color: Colors.black, fontSize: 16),
                        ),
                      ),
                    ),
                  ],
                ),
              ),
            ],
          ),
        ));
  }
}

Screenshots or Video

Screenshots / Video demonstration

[Upload media here]

Logs

Logs
[Paste your logs here]

Flutter Doctor output

Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[!] Flutter (Channel stable, 3.19.5, on Microsoft Windows [版本 10.0.22631.3447], locale zh-CN)
    ! Warning: `flutter` on your path resolves to E:\Solfwares\SDK\flutter_3.7.12\bin\flutter, which is not
      inside your current Flutter SDK checkout at E:\Solfwares\SDK\flutter_3.19.5. Consider adding
      E:\Solfwares\SDK\flutter_3.19.5\bin to the front of your path.
    ! Warning: `dart` on your path resolves to E:\Solfwares\SDK\flutter_3.7.12\bin\dart, which is not inside
      your current Flutter SDK checkout at E:\Solfwares\SDK\flutter_3.19.5. Consider adding
      E:\Solfwares\SDK\flutter_3.19.5\bin to the front of your path.
[√] Windows Version (Installed version of Windows is version 10 or higher)
[!] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    ! Some Android licenses not accepted. To resolve this, run: flutter doctor --android-licenses
[√] Chrome - develop for the web
[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.6.5)
[!] Android Studio (version 3.6)
    X Unable to find bundled Java version.
[√] Android Studio (version 2022.3)
[√] Connected device (4 available)
@indeedshaw
Copy link
Author

indeedshaw commented May 6, 2024

see:#66087
Highlights need to be displayed in other ways?

@nate-thegrate
Copy link
Member

nate-thegrate commented May 7, 2024

I ran your code sample on Windows, and it seems to be working:

Maybe your issue is related to the Flutter doctor output:

[!] Flutter (Channel stable, 3.19.5, on Microsoft Windows [版本 10.0.22631.3447], locale zh-CN)
    ! Warning: `flutter` on your path resolves to E:\Solfwares\SDK\flutter_3.7.12\bin\flutter, which is not
      inside your current Flutter SDK checkout at E:\Solfwares\SDK\flutter_3.19.5. Consider adding
      E:\Solfwares\SDK\flutter_3.19.5\bin to the front of your path.
    ! Warning: `dart` on your path resolves to E:\Solfwares\SDK\flutter_3.7.12\bin\dart, which is not inside
      your current Flutter SDK checkout at E:\Solfwares\SDK\flutter_3.19.5. Consider adding
      E:\Solfwares\SDK\flutter_3.19.5\bin to the front of your path.

@darshankawar darshankawar added the in triage Presently being triaged by the triage team label May 7, 2024
@indeedshaw
Copy link
Author

I ran your code sample on Windows, and it seems to be working:

Maybe your issue is related to the Flutter doctor output:

[!] Flutter (Channel stable, 3.19.5, on Microsoft Windows [版本 10.0.22631.3447], locale zh-CN)
    ! Warning: `flutter` on your path resolves to E:\Solfwares\SDK\flutter_3.7.12\bin\flutter, which is not
      inside your current Flutter SDK checkout at E:\Solfwares\SDK\flutter_3.19.5. Consider adding
      E:\Solfwares\SDK\flutter_3.19.5\bin to the front of your path.
    ! Warning: `dart` on your path resolves to E:\Solfwares\SDK\flutter_3.7.12\bin\dart, which is not inside
      your current Flutter SDK checkout at E:\Solfwares\SDK\flutter_3.19.5. Consider adding
      E:\Solfwares\SDK\flutter_3.19.5\bin to the front of your path.

Yes,the display on the window is normal. I tested on a mobile device. Try this on a mobile device.I've modified the reproduction steps.

@darshankawar
Copy link
Member

@indeedshaw
I tried on Android 13 emulator and it seems to be working as intended:

147859.mov

@darshankawar darshankawar added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label May 7, 2024
@nate-thegrate
Copy link
Member

I can confirm @darshankawar's observation:

@indeedshaw
Copy link
Author

In my case, it happen with a short press.Maybe we can change the highlight color so we can see better. @darshankawar @nate-thegrate

S40507-15595002.mp4

@github-actions github-actions bot removed the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label May 7, 2024
@darshankawar
Copy link
Member

darshankawar commented May 8, 2024

Thanks for the update. I re-ran the provided code sample and with short press it seems the reported behavior as replicable specially on mobile platform.

147859.mov
stable, master flutter doctor -v
[!] Flutter (Channel stable, 3.19.6, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.19.6 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 54e66469a9 (6 days ago), 2024-04-17 13:08:03 -0700
    • Engine revision c4cd48e186
    • Dart version 3.3.4
    • DevTools version 2.31.1
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.22.0-27.0.pre.12, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 3.22.0-27.0.pre.12 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 0b3a88f218 (2 hours ago), 2024-05-07 22:42:36 -0400
    • Engine revision 0a469aa59c
    • Dart version 3.5.0 (build 3.5.0-131.0.dev)
    • DevTools version 2.35.0
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/dhs/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for
      more details.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13C100
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 65.1.4
    • Dart plugin version 213.7228

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.29.0

[✓] Connected device (3 available)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 15.3.1 19D52
    • macOS (desktop)           • macos                                    •
      darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 109.0.5414.119

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.
      
[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.



Maybe related #110300 ?

@darshankawar darshankawar changed the title InkWell highlight not working InkWell highlight not working inside PageView May 8, 2024
@darshankawar darshankawar added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. has reproducible steps The issue has been confirmed reproducible and is ready to work on team-design Owned by Design Languages team found in release: 3.19 Found to occur in 3.19 found in release: 3.22 Found to occur in 3.22 and removed in triage Presently being triaged by the triage team labels May 8, 2024
@darshankawar darshankawar changed the title InkWell highlight not working inside PageView InkWell highlight not working inside PageView on mobile platform. May 8, 2024
@indeedshaw
Copy link
Author

Thank you for your reply, This problem can be replicated not only in PageViews.I tried using GestureDector's onDobuleTap or some other input that is different from onTap and got the same results, they are probably related.
Maybe like #66087, because _InkResponseState's _startNewSplash is already executed.
Should I close the issue and wait for the progress of #110300?

@Piinks Piinks added triaged-design Triaged by Design Languages team P3 Issues that are less important to the Flutter project labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: material design flutter/packages/flutter/material repository. found in release: 3.19 Found to occur in 3.19 found in release: 3.22 Found to occur in 3.22 framework flutter/packages/flutter repository. See also f: labels. has reproducible steps The issue has been confirmed reproducible and is ready to work on P3 Issues that are less important to the Flutter project team-design Owned by Design Languages team triaged-design Triaged by Design Languages team
Projects
None yet
Development

No branches or pull requests

4 participants