New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[M2] Snackbar is not properly aligned when using RTL Directionality #147838
Labels
f: material design
flutter/packages/flutter/material repository.
found in release: 3.19
Found to occur in 3.19
found in release: 3.22
Found to occur in 3.22
framework
flutter/packages/flutter repository. See also f: labels.
has reproducible steps
The issue has been confirmed reproducible and is ready to work on
r: fixed
Issue is closed as already fixed in a newer version
team-design
Owned by Design Languages team
Comments
danagbemava-nc
changed the title
Snackbar alignment issue on RTL case using M2
[M2] Snackbar is not properly aligned when using RTL Directionality
May 6, 2024
Reproducible using the code sample provided above. Screen.Recording.2024-05-06.at.09.24.06.movflutter doctor -v
|
danagbemava-nc
added
framework
flutter/packages/flutter repository. See also f: labels.
f: material design
flutter/packages/flutter/material repository.
has reproducible steps
The issue has been confirmed reproducible and is ready to work on
team-design
Owned by Design Languages team
found in release: 3.19
Found to occur in 3.19
found in release: 3.22
Found to occur in 3.22
and removed
in triage
Presently being triaged by the triage team
labels
May 6, 2024
auto-submit bot
pushed a commit
that referenced
this issue
May 8, 2024
## Description This PR fixes floating `SnackBar` positioning when the text direction is RTL and the theme uses Material 2. In #140215, I fixed the `SnackBar` position for M3/RTL, but while doing so I broke the positioning for M2/RTL... Unfortunately, there was no existing test for this case. The solution is to not rely on `TextDirection` to compute the `SnackBar` position: the `SnackBar` is centered in both cases so the text direction has no impact on its positioning (it had some impact in the `SnackBar` content, but this is managed correctly). ## Related Issue Fixes #147838. ## Tests Adds 1 test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
f: material design
flutter/packages/flutter/material repository.
found in release: 3.19
Found to occur in 3.19
found in release: 3.22
Found to occur in 3.22
framework
flutter/packages/flutter repository. See also f: labels.
has reproducible steps
The issue has been confirmed reproducible and is ready to work on
r: fixed
Issue is closed as already fixed in a newer version
team-design
Owned by Design Languages team
Steps to reproduce
Create snacker with M2 theme and RTL directionality with specific width
Expected results
Set anckbar on center
Actual results
not set anckbar on center
Code sample
Code sample
Screenshots or Video
Screenshots / Video demonstration
[Upload media here]
Logs
Logs
Flutter Doctor output
Doctor output
using dartpad
The text was updated successfully, but these errors were encountered: